Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Advanced_Sounding_With_Complex_Layout.py #3204

Merged
merged 8 commits into from
Oct 10, 2023

Conversation

kylejgillett
Copy link
Contributor

Apologies for the delay, I was distracted by meso and modeling homework, and Aurora the past few days :).

I also somehow goofed up some of the linting checks, so I am resubmitting this again, all nice and clean.

Description Of Changes

This is an updated version of PR #3161 which included some errors when docs were created.

Corrected commenting errors.
Added 'Advanced' to the title.
Added [0] to the supercell_comp & sig_tor variables for future NumPy handing of the int() function.
Adjusted axes and figtext() x/y locations some to hopefully correct the strange plt.show() behaviors.

Thanks for your help!

@kylejgillett kylejgillett requested a review from a team as a code owner September 20, 2023 22:48
@kylejgillett kylejgillett requested review from dopplershift and removed request for a team September 20, 2023 22:48
Copy link
Collaborator

@kgoebber kgoebber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All nearly looks good. I was able to build the docs and visualize that the image looks good. Just a few blank lines needing to be put in to make the doc builds happy.

Also, we'll want to remove the old version of the example (Complex-Sounding-Plot.py) so we don't have two versions in the docs!

git rm Complex-Sounding-Plot.py

issued from the examples folder should remove it from tracking. Then you can also delete it from your working folder.

examples/Advanced_Sounding_With_Complex_Layout.py Outdated Show resolved Hide resolved
examples/Advanced_Sounding_With_Complex_Layout.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@kgoebber kgoebber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example is now passing! Yeah! Just a few other small things to clean up and make the example more readable. Then we should be good to go to get this in.

examples/Advanced_Sounding_With_Complex_Layout.py Outdated Show resolved Hide resolved
examples/Advanced_Sounding_With_Complex_Layout.py Outdated Show resolved Hide resolved
@kgoebber
Copy link
Collaborator

kgoebber commented Oct 5, 2023

All looks good. Just need to wait for codecov to come back and then we'll be all set. Thanks @kylejgillett for making all of the updates!

@kylejgillett
Copy link
Contributor Author

Thanks for your help getting it through the checks and double checking how it looks in the docs, @kgoebber!

Appreciate the opportunity to contribute!

@kgoebber kgoebber merged commit c6ea879 into Unidata:main Oct 10, 2023
28 checks passed
@github-actions github-actions bot added this to the September 2023 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants