-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Advanced_Sounding_With_Complex_Layout.py #3204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All nearly looks good. I was able to build the docs and visualize that the image looks good. Just a few blank lines needing to be put in to make the doc builds happy.
Also, we'll want to remove the old version of the example (Complex-Sounding-Plot.py) so we don't have two versions in the docs!
git rm Complex-Sounding-Plot.py
issued from the examples folder should remove it from tracking. Then you can also delete it from your working folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example is now passing! Yeah! Just a few other small things to clean up and make the example more readable. Then we should be good to go to get this in.
All looks good. Just need to wait for codecov to come back and then we'll be all set. Thanks @kylejgillett for making all of the updates! |
Thanks for your help getting it through the checks and double checking how it looks in the docs, @kgoebber! Appreciate the opportunity to contribute! |
Apologies for the delay, I was distracted by meso and modeling homework, and Aurora the past few days :).
I also somehow goofed up some of the linting checks, so I am resubmitting this again, all nice and clean.
Description Of Changes
This is an updated version of PR #3161 which included some errors when docs were created.
Thanks for your help!