Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build binary wheels for people that don't have a c-compiler #84

Closed
jswhit opened this issue Nov 15, 2018 · 12 comments
Closed

build binary wheels for people that don't have a c-compiler #84

jswhit opened this issue Nov 15, 2018 · 12 comments

Comments

@jswhit
Copy link
Collaborator

jswhit commented Nov 15, 2018

Right now we just put a source tarball on pypi, along with binary wheels for windows from Christoph Gohlke's site. We could set up a MacPython project to build macos x and linux wheels, as we do or netcdf4-python, or use cibuildwheel. Anyone here know anything about cibuildwheel?

@huard
Copy link
Contributor

huard commented Nov 16, 2018

Note that when doing pip install cftime on an environment with no cython installed, the install process just hangs there and no feedback is returned to the user.

@jswhit jswhit mentioned this issue Nov 29, 2018
@rabernat
Copy link

Doesn't the conda-forge package meet this need?
https://github.com/conda-forge/cftime-feedstock

@jswhit
Copy link
Collaborator Author

jswhit commented Nov 29, 2018

That allows cftime to be installed with conda, but I don't think it allows creation of binary wheels that can be uploaded to pypi for installation with pip.

@jswhit
Copy link
Collaborator Author

jswhit commented Nov 29, 2018

The issue that @huard mentions above needs to be fixed before 1.0.3 is released. I have no idea at this point what causes it.

@ocefpaf
Copy link
Contributor

ocefpaf commented Nov 29, 2018

The issue that @huard mentions above needs to be fixed before 1.0.3 is released. I have no idea at this point what causes it.

Not sure what version you are testing @huard but this was fixed a while back when we moved cython to the setup_requires.

Regarding wheels, I'm not familiar with it, but I believe multibuild is the way to go.

@jswhit
Copy link
Collaborator Author

jswhit commented Nov 29, 2018

I have not been able to reproduce the issue with pip hanging in an environment without cython that @huard reported. I will go ahead and release 1.0.3. I'll also ask @matthew-brett to create a MacPython/cftime-wheels project for us.

@huard
Copy link
Contributor

huard commented Nov 30, 2018

I haven't been able to reproduce it either. The only guess I can make is that this was in a outdated conda environment with an old version of pip.

@ocefpaf
Copy link
Contributor

ocefpaf commented Nov 30, 2018

I haven't been able to reproduce it either. The only guess I can make is that this was in a outdated conda environment with an old version of pip.

Probably, I don't recall in which version the setup_requires was added but it is kind of a new thing.

@jswhit
Copy link
Collaborator Author

jswhit commented Dec 1, 2018

@matthew-brett has kindly created https://github.com/MacPython/cftime-wheels for us, so linux and macosx wheels can now be built automatically.

@jswhit jswhit closed this as completed Dec 1, 2018
@NotSqrt
Copy link

NotSqrt commented Dec 3, 2018

Will there be manylinux wheels for v1.0.3 ?
That would help bypass #34
Thanks !

@jswhit
Copy link
Collaborator Author

jswhit commented Dec 3, 2018

There will be as soon as @matthew-brett adds me to the cftime-wheels project so I can trigger a build.

@matthew-brett
Copy link
Collaborator

@jswhit - did you see my earlier message on that? Have you tried triggering a build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants