Add only_use_cftime_datetimes flag to num2date #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37
I tried to go for the path of least resistance. I added a flag to
DateFromJulianDay
that allows one to bypass the logic that usesdatetime.datetime
objects in certain situations (and exposed that flag innetcdftime.num2date
). Ifonly_use_netcdftime_datetimes
isTrue
we have the following behavior:calendar='standard'
,DatetimeGregorian
objects are always usedcalendar='gregorian'
,DatetimeGregorian
objects are always usedcalendar='proleptic_gregorian'
,DatetimeProlepticGregorian
objects are always usedIf
only_use_netcdftime_datetimes
isFalse
(which is the default), then the original behavior occurs.Does this seem like something reasonable? I'm happy to discuss things further.