Use nc-config in configure to check capabilities #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only for autotools build system, not CMake
WardF
added a commit
that referenced
this pull request
Dec 6, 2016
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jun 3, 2023
\Brief Release notes file for the netcdf-cxx4 package. This file contains a high-level description of this package's evolution. Releases are in reverse chronological order (most recent first). Note that this file was created and maintained starting with the `netcdf-cxx4 4.3.0 release`. ## netCDF-CXX4 4.3.2 TBD ## netCDF-CXX4 v4.3.1 September 11, 2019 ### Requirements * netCDF-C 4.6.0 or greater ### Changes * [Enhancement] Added cmake support to distribution files created by `make dist`. * [Bug Fix] Added `ncFile::create()`, also added a new `open` function and constructor to allow for more flexibility when opening a file. See [GitHub #55](Unidata/netcdf-cxx4#55) for more information. * [Enhancement] Addressed an issue reported with `Intel Compilers 17.0.0`. See [GitHub #41](Unidata/netcdf-cxx4#41) for more information. * [Enhancement] Updated how `configure` determines information about the existing netCDF-C install. See [GitHub pull request #39](Unidata/netcdf-cxx4#39) for more information. * Corrected an issue where cmake-based builds weren't generating `ncxx4-config`. See [GitHub pull request #37](Unidata/netcdf-cxx4#37) for more information. ## netcdf-cxx4 v4.3.0 released May 13, 2016 * Fixed an issue where the tests were failing silently, and the underlying `NcType` class could not properly determine the type name or type size reliably. See [GitHub issue #30](Unidata/netcdf-cxx4#30) for more information. * Changed `NCXX_ENABLE_DOXYGEN` option to an easier-to-remember `ENABLE_DOXYGEN`. * Added `--enable-doxygen`, `-DNCXX_ENABLE_DOXYGEN=ON` options to allow generation of netCDF-CXX4 documentation via doxygen using either `configure` or `cmake`, respectively. * Added `netcdf-cxx4` to the [Coverity Scan Dashboard](https://scan.coverity.com/projects/unidata-netcdf-cxx4?tab=overview). * Added `open` and `close` methods for NcFile. See [Github Pull Request #18](Unidata/netcdf-cxx4#18) for more information. * Added `netcdf-cxx4` to travis-ci.org. See [https://travis-ci.org/Unidata/netcdf-cxx4](https://travis-ci.org/Unidata/netcdf-cxx4) for more details. * Added `NcCompoundType` methods `getMemberName` and `getMemberIndex`. See [Pull Request #19](Unidata/netcdf-cxx4#19) for more details. * Added `cmake` support to `netcdf-cxx4`, which will allow us to create a `CDash` continuous integration dashboard similar to those created for the `netcdf-c` and `netcdf-fortran` projects. * Added a `travis-ci` configuration file, `.travis.yml`. * Created `RELEASE_NOTES.md`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
configuresearches for the NetCDF header and library, and checks for various functions in order to determine what capabilities it has. However,nc-config, which comes with most (all?) NetCDF distributions already has this information.This PR adds the flags
--with-nc-config/--without-nc-configto./configure. If--without-nc-configis specified, thenconfigureuses the current method to determine functionality. Otherwise, it will usenc-configfrom either$PATH, or the path supplied to--with-nc-config=<path>. This always different NetCDF-C installations to be used, and not just the default system one.Unfortunately, I don't know enough CMake to add it to that build system as well, but presumably this could be done.
Also, although it doesn't appear that you actually link against NetCDF-C,
nc-configcould also supplyLDFLAGS, LIBS, CPPFLAGSif needed.