Add Grib2 template 4.60 #1164
Add Grib2 template 4.60 #1164
Conversation
|
|
|
The correct name for this is: |
Got it. By the way, the added template was verified using MeteoInfoLab with ECMWF S2S Grib2 data with the template 4.60. |
Yaqiang
force-pushed
the
grib2-template-4.60
branch
from
1a1e914
to
f60e40f
Compare
…e forecasting data of ECMWF, and overload EnsCoorValue constructor with ensNumber parameter to read all members with save pertubation number
haileyajohnson
force-pushed
the
grib2-template-4.60
branch
from
f9784e1
to
9813f88
Compare
| @@ -432,7 +432,7 @@ else if (isRegular) | |||
| for (int i = 0; i < pc.getValuesCount(); i++) { | |||
| double val1 = pc.getValues(i); | |||
| double val2 = pc.getBound(i); | |||
| ecoords.add(new EnsCoordValue((int) val1, (int) val2)); | |||
| ecoords.add(new EnsCoordValue((int) val1, (int) val2, i + 1)); | |||
There was a problem hiding this comment.
This is sort of a dummy coord, isn't it? Can we just leave out the i+1? Other than that I think this all looks good.
There was a problem hiding this comment.
Yes, it is sort of a dummy coord. i + 1 was used because no better choice on my side.
|
you will also need to apply code style to get the checks to pass: |
|
Moved to #1192 |
Description of Changes
Add Grib2 template 4.60 Grib2Pds60 inner class to support s2s ensemble forecasting data of ECMWF.
PR Checklist
until ready for review