Improve test reliability #1298
Merged
Improve test reliability #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdrwenski
force-pushed
the
improve-tests
branch
from
fe8b228
to
f58a507
Compare
…s before test class instead of 0
haileyajohnson
force-pushed
the
improve-tests
branch
from
f58a507
to
b9254d2
Compare
haileyajohnson
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve test reliability by checking the actual connections is same as before and after test instead of checking it is 0.
The
actualconnectionswill increase any time a newHTTPConnectionis opened, but if this isn't opened with try-with-resources, the connection may not be closed. So if we check if theactualconnections == 0in our tests, we are testing that everywhere in the tests run before theHTTPConnectionshave been closed properly, which probably is not always the case.Description of Changes
Erase this and add a general description of changes, heads-up on any tricky parts, etc., here.
PR Checklist
until ready for review