Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix "critical bugs" from sonarcloud. #37

Merged
merged 4 commits into from
Jul 30, 2019
Merged

fix "critical bugs" from sonarcloud. #37

merged 4 commits into from
Jul 30, 2019

Conversation

JohnLCaron
Copy link
Collaborator

Fix 7/8 bugs. The other one is false positive.

@lesserwhirls
Copy link
Collaborator

@dopplershift - would you mind taking a look at cdm/src/main/java/ucar/nc2/iosp/nexrad2/Level2VolumeScan.java? There are a lot of formatting changes, but a few others as well.

@dopplershift
Copy link
Member

@lesserwhirls I think those changes look reasonable.

@lesserwhirls
Copy link
Collaborator

Thanks @JohnLCaron @dopplershift!

@lesserwhirls lesserwhirls merged commit 32fed0c into Unidata:master Jul 30, 2019
@lesserwhirls lesserwhirls mentioned this pull request Jul 31, 2019
Closed
@JohnLCaron JohnLCaron deleted the fixCritialBugs branch August 6, 2019 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesserwhirls lesserwhirls Awaiting requested review from lesserwhirls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JohnLCaron @lesserwhirls @dopplershift @jlcaron