Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cdm tests. #57

Merged
merged 1 commit into from
Aug 17, 2019
Merged

Fix cdm tests. #57

merged 1 commit into from
Aug 17, 2019

Conversation

JohnLCaron
Copy link
Collaborator

Some miscellaneous cdm-test fixes.
Tried to work with Categories; may not be working fully with IntelliJ-launched unit tests (?)
Also some changes to files in /cdmUnitTest/ eg
/cdmUnitTest/conventions/cfradial/cfrad.20171127_202111.203_to_20171127_202123.085_DOW7_v275_s04_el7.00_SUR.nc
Can I get at Unidata's copy o those files, or do you have to send to me??

@JohnLCaron
Copy link
Collaborator Author

Does Jenkins run cdm-test? Can I find out how it did?

@lesserwhirls
Copy link
Collaborator

Hi @JohnLCaron - sorry for the delay. Here is a copy of that file (zip compressed):

cfrad.20171127_202111.203_to_20171127_202123.085_DOW7_v275_s04_el7.00_SUR.nc.zip

We tried hosing the test datasets on git lfs, but it more than doubled the size of the test datasets on disk due to the way git works, so it was a no-go. Hopefully we'll have the test data publicly accessible in the next week or so. I'm happy to add/remote/update/fetch any datasets you need until we get that up and running.

Jenkins runs the full test suite, including the stuff in cdm-test. I've tried running your PR twice today, and both times we are getting hung up on ucar.nc2.util.cache.TestNetcdfFileCache.testPeriodicClear():

ucar.nc2.util.cache.TestNetcdfFileCache > testPeriodicClear STANDARD_OUT
     InterruptedException=sleep interrupted
     InterruptedException=sleep interrupted
     InterruptedException=sleep interrupted

We've had this problem periodically, and recently we added some debug statements to try to diagnose it...however, none of those messages showed up, so we didn't hit up the correct places. It does not happen consistently, unfortunately (never been able to catch it in the debugger). I'll give it a spin again and we'll see.

BTW - the Jenkins github authentication plugin has been fixed, so soon you'll be able to use that to access Jenkins. At that point, you'll be able to run tests on your branches whenever you need to.

@lesserwhirls
Copy link
Collaborator

I'm going to go ahead and merge this PR, and will add an issue about enabling the slow category. I can take care of that.

@JohnLCaron
Copy link
Collaborator Author

JohnLCaron commented Aug 17, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants