Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime support for AWS Security Token Service #297

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

lesserwhirls
Copy link
Collaborator

@lesserwhirls lesserwhirls commented Oct 7, 2022

See #194 (specifically #194 (comment)).


This change is Reviewable

@lesserwhirls lesserwhirls marked this pull request as ready for review October 7, 2022 02:32
@WeatherGod
Copy link
Contributor

Running an experiment now on my system by copying the sts-2.17.156.jar over into webapps/thredds/WEB-INF/lib/ in the unidata/thredds-docker:5.4 image, since my CI/CD is currently set up to use that.

@WeatherGod
Copy link
Contributor

Success!

While I didn't specifically test out this patch, I can confirm that just simply adding the sts jar file to the classpath will allow thredds to host S3 data when running in EKS (and possibly ECS?).

@WeatherGod
Copy link
Contributor

Would it also be worth adding at least some notes on how to add logging for the aws sdk to the documentation? Personally, I would leave out the http part as that made the logs unbearably noisy. The awssdk specific parts were absolutely crucial in figuring this problem out, and I would imagine it would be helpful going forward for any other user trying to debug S3 issues.

@tdrwenski
Copy link
Contributor

@WeatherGod I will have a look at adding aws sdk logging in a separate PR-- probably just warn and higher to prevent noise.

@tdrwenski tdrwenski merged commit 335f5dd into Unidata:main Oct 7, 2022
@WeatherGod
Copy link
Contributor

Fair enough. I'll note that I initially tried setting them to info, and got no output. So, even the failure to load the sts module when the appropriate environment variable was found was buried as a "debug". But even just having the entries in the logging eonfigs will give users a foothold to turn the logs on when they need it.

@tdrwenski
Copy link
Contributor

@WeatherGod you can see my PR here: #298. I also added something to the FAQs, so hopefully that could be helpful. Feel free to comment there if you have suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants