Overhaul test suite with fixtures #2675

This creates a PostgreSQL fixture that can be depended on by tests that require a running PostgreSQL server with the NAV database to be present. The fixture will work with externally set up PostgreSQL servers, like in the case of GitHub Actions, while it can also provision a PostgreSQL server with the NAV schema using Docker if run locally.

This ensures any tests that rely on the various pre-existing db-related fixtures will have a running PostgreSQL server available.

This ensures the postgres fixture is started for all tests that inherit from DjangoTransactionTestCase

Change TestCase implementations that should really be transactional test cases (which in turn ensures they have PostgreSQL available through the postgres fixture, and that transactions are properly rolled back after the tests have run)

Declares a dependency on the postgresql fixture to ensure the NAV database is actually available for these tests

This ensures that any test that depends on a logged in web client also automatically depends on having the NAV database running.

This ensure the snmpsim fixture can run both on Linux and MacOS, by replacing Linux specific parts (like looking at /proc/net/udp). This slightly changes the logic of verifying whether the snmpsimd process is up and running before yielding the fixture value: Instead of waiting for something to appear to listen to port 1024, this verifies the presence of the SNMP agent by performing an actual SNMP query.

These imports made the entire test module depend on the PostgreSQL database actually running. Moving the imports to be local to the tests (that depend directly or indirectly) on the postgresql fixture ensures that the imports only take place after PostgreSQL is actually running.

The admin_navlet fixture is dynamic/parametrized, which is why its implementation is a bit weird. Unfortunately, the tests that depend on it currently fail under the new regime of the postgresql fixture. Adding this note so we know where to go back and fix it.

While pytest can accomplish a lot of exciting things, it cannot use fixtures as input to test parametrization. While can make a test depend on a fixture for getting a postgresql instance, the test discovery phase that generates the tests cannot. I.e. we cannot get our test parameters from a database unless the database was already up and running when the test discovery phase started. Sad, but true,. This changes the navlet test to iterate over the available admin navlets itself.

These tests would only work incidentally; i.e. if they ran after another test that depended on the postgresql fixture

The postgresql fixture is fine to depend on if you just need a database to be present. But if you need to write data during the test, you should probably use the db fixture.

For now, at least. If the Open-LDAP libraries aren't available locally, the test suite will fail because python-ldap will not build.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Overhaul test suite with fixtures #2675

Overhaul test suite with fixtures #2675

Commits on Sep 24, 2024