Enable SNMPv3 write profile checks in SeedDB #2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2730 +/- ##
==========================================
+ Coverage 55.32% 55.46% +0.13%
==========================================
Files 567 567
Lines 41052 41175 +123
==========================================
+ Hits 22713 22838 +125
+ Misses 18339 18337 -2 ☔ View full report in Codecov by Sentry. |
hmpf
reviewed
Nov 13, 2023
lunkwill42
force-pushed
the
feature/snmpv3-seeddb-write-profiles
branch
from
55c77b8
to
23222a8
Compare
Enable write access to snmpdv3 instance as well, so that snmp SET commands also can be tested properly.
This just makes the SeedDB write profile test work by delegating SNMP session establishment to the new get_snmp_session_for_profile function.
lunkwill42
force-pushed
the
feature/snmpv3-seeddb-write-profiles
branch
from
23222a8
to
2b6cfb6
Compare
johannaengland
approved these changes
Nov 14, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This augments #2734 and closes #2727.
This includes reworking the snmpdv3 example container to allow for testing write operations.