Added sort methods to util\Collection and data\Collection #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful if you want to do application side sorting on data from a
RecordSet or DocumentSet. An example would be where you want to displa
y the top N most popular posts ordered by date. To do this you would qu
ery the data layer for posts ordered by "popularity" and then limit the
query by N. Now you must sort the data by date in your application, usi
ng RecordSet::sort('date').
|
This needs a bit of cleanup per coding standards. Also, I think a bit of refactoring to reduce if blocks / nesting is in order. Otherwise, good work. |
nateabele
added a commit
that referenced
this pull request
Aug 11, 2011
Added sort methods to util\Collection and data\Collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful if you want to do application side sorting on data from a RecordSet or DocumentSet. An example would be where you want to display the top N most popular posts ordered by date. To do this you would query the data layer for posts ordered by "popularity" and then limit the query by N. Now you must sort the data by date in your application, using RecordSet::sort('date').
If there is more procedure than simply submitting a pull request to get changes in, let me know :)