Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

From Controller, look for view in own library #650

Merged
merged 1 commit into from Sep 21, 2012

Conversation

Projects
None yet
4 participants
Contributor

yitznewton commented Sep 19, 2012

To this point, li3 defaults to app/views. With this change, li3 looks by
default in libraries/foo/views/, where foo is the library containing the
Controller.

Redo of #639 to point to dev

Owner

nateabele commented Sep 19, 2012

Nice, just one thing: it looks like your editor is adding newlines to the end of the files. If you can fix that and squash your commits, I'll merge it ASAP. Thanks!

From Controller, look for view in own library
To this point, li3 defaults to app/views. With this change, li3 looks by
default in libraries/foo/views/, where foo is the library containing the
Controller.

remove newlines at EOF
Member

d1rk commented Sep 21, 2012

That is nice. As i already stated on StackOverflow, the current way to do this is far from perfect. Eager to see that in.

Owner

nateabele commented Sep 21, 2012

Hey! Sorry, for whatever reason I didn't get the notification that you updated this, thanks!

nateabele added a commit that referenced this pull request Sep 21, 2012

Merge pull request #650 from yitznewton/dev
From Controller, look for view in own library

@nateabele nateabele merged commit 1d6fae0 into UnionOfRAD:dev Sep 21, 2012

1 check passed

default The Travis build passed
Details

There is small problem, that now controller tries to pull the layout also from library. Before this change I was constantly told, that this feature is unneeded. Now it's implemented into core.

Member

d1rk replied Oct 11, 2012

It should look for the view in the library, then for a layout in the library, but if it does not find one, take the one from app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment