Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semaphore v4 #546

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Fix semaphore v4 #546

merged 2 commits into from
Sep 20, 2023

Conversation

vivianjeng
Copy link
Member

@vivianjeng vivianjeng commented Sep 19, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally in root directory and any changes were pushed
  • Lint (yarn lint:fix) was run locally in root directory and any changes were pushed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: close #541

What is the new behavior?

  • Semaphore v4
  1. Variable names:
    1. External Nullifier → Scope
    2. Siblings → Tree Siblings
    3. Path Indices → Tree Indices
  2. Simplified identity: The two old identity secrets (trapdoor and nullifier) have been replaced by 1 secret only (secret). So identity commitment = hash(identity secret), and nullifier hash = hash(scope, identity secret).

Does this introduce a breaking change?

  • Yes
  • No

Other information

@vivianjeng vivianjeng merged commit be1207b into main Sep 20, 2023
@vivianjeng vivianjeng deleted the fix-semaphore-v4 branch September 20, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update semaphore v4
1 participant