Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double spend via delegatecall #177

Closed
wants to merge 1 commit into from

Conversation

k06a
Copy link

@k06a k06a commented Jan 18, 2023

@marktoda
Copy link
Collaborator

marktoda commented Feb 1, 2023

Thanks for submitting! We considered this during development but decided against explicitly supporting delegatecalls to permit2 -- we think that permit2 works best when theres a single instance to get maximal network effects. If other teams have improvements or special needs, then a fully separate deployment is best. Happy to discuss further but closing for now

cc @snreynolds

@marktoda marktoda closed this Feb 1, 2023
@k06a
Copy link
Author

k06a commented Feb 1, 2023

I understand that intention to delegatecall this code is wrong, but it was an attempt to protect developers/users even from misuse, especially if this protection would costs almost zero gas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants