fix: update token fetcher sampling comparison logic to ignore empty/0 fees #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphite-app
bot
requested review from
jsy1218,
a team,
cgkol,
mikeki and
uni-guillaume
Graphite Automations"Request reviewers once CI passes on routing-api repo" took an action on this PR • (06/18/24)6 reviewers were added and 1 assignee was added to this PR based on 's automation. |
jsy1218
reviewed
Jun 18, 2024
jsy1218
reviewed
Jun 18, 2024
test/mocha/unit/traffic-switch/traffic-switcher-i-token-fee-fetcher.test.ts
Show resolved
Hide resolved
jsy1218
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update on the sampling comparison logic between OnchainFeeFetcher and GraphQLFeeFetcher to ignore entries that are empty or have 0 fees and pollute comparison logs.
example
TrafficSwitcherITokenFeeFetcher compareResultsForFetchFees: Different fee for address 0x4da27a545c0c5b758a6ba100e3a049001de870f5: in control: {"buyFeeBps":{"type":"BigNumber","hex":"0x00"},"sellFeeBps":{"type":"BigNumber","hex":"0x00"}} and treatment: {}