This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
feat: lowercase address checking when doing token comparisons #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFrankfurt
approved these changes
Mar 6, 2023
Comment on lines
57
to
61
| public sortsBefore(other: Token): boolean { | ||
| invariant(this.chainId === other.chainId, 'CHAIN_IDS') | ||
| invariant(this.address !== other.address, 'ADDRESSES') | ||
| invariant(this.address.toLowerCase() !== other.address.toLowerCase(), 'ADDRESSES') | ||
| return this.address.toLowerCase() < other.address.toLowerCase() | ||
| } |
There was a problem hiding this comment.
might be worth adding a test case for this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Tokens can now have non-checksummed addresses, we need to lowercase addresses before doing comparison checking because we could be comparing one with checksummed addresses to one without. Theoretically they're the same token, so its OK to not do case-sensitive comparisons here