chore(release): fix breaking change marker #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marktoda
reviewed
Apr 26, 2024
| @@ -6,7 +6,7 @@ Please title your PR according to the following types and scopes following [conv | |||
| - `chore(<type>):` will not trigger any release and should be used for internal repo changes | |||
| - `<type>(public):` will trigger a patch version for non-code changes (e.g. README changes) | |||
| - `feat(SDK name):` will trigger a minor version | |||
| - `feat(!):` will trigger a major version for a breaking change | |||
| - `feat(breaking):` will trigger a major version for a breaking change | |||
There was a problem hiding this comment.
does this scope to a specific SDK? if so how
ie can I do feat(breaking sdk-core)?
There was a problem hiding this comment.
The scope will need to be breaking literal, but which SDK it affects will only be based on the files changed! So changing for sdk-core would mean only touching files in that SDK for the PR with that title and semantic-release will handle automatically!
marktoda
approved these changes
Apr 26, 2024
jsy1218
approved these changes
Apr 26, 2024
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (04/26/24)1 assignee was added and 2 reviewers were added to this PR based on 's automation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to rules being a glob, the
!marker was treated as a negation and accidentally treated all minor version bumps as major. This removes that possibility!