-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-core): support zksync on V3 #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jsy1218
changed the title
feat(sdk-core): support zksync
feat(sdk-core): support zksync on V3
Jun 5, 2024
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (06/05/24)1 reviewer was added and 1 assignee was added to this PR based on 's automation. |
marktoda
reviewed
Jun 5, 2024
hensha256
approved these changes
Jun 5, 2024
mikeki
approved these changes
Jun 5, 2024
cgkol
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
🎉 This PR is included in version @uniswap/sdk-core-v5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have deployed V3 to to ZkSync. We are updating the SDKs to support V3 in FE and BE. First step is to update sdk-core
How Has This Been Tested?
unit tests
Are there any breaking changes?
No
(Optional) Feedback Focus
No
(Optional) Follow Ups
We will have to create v2-sdk and v3-sdk and universal-router-sdk changes separately, because we still publish individual sdk packages to npm repo.