feat(uniswapx-sdk): change MULTICALL_ADDRESS to be chainId specific #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or zksync support
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (06/17/24)1 reviewer was added and 1 assignee was added to this PR based on 's automation. |
ConjunctiveNormalForm
approved these changes
Jun 17, 2024
|
🎉 This PR is included in version @uniswap/uniswapx-sdk-v2.1.0-beta.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
DevZi1la
pushed a commit
to taraswap/sdks
that referenced
this pull request
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Scope
Please title your PR according to the following types and scopes following conventional commits:
fix(SDK name):will trigger a patch versionchore(<type>):will not trigger any release and should be used for internal repo changes<type>(public):will trigger a patch version for non-code changes (e.g. README changes)feat(SDK name):will trigger a minor versionfeat(breaking):will trigger a major version for a breaking changeDescription
Since zksync has a different implementation of CREATE2, addresses are no longer consistent with other EVM chains. We've seen this in permit2 deployments. This PR updates the default exports of uniswapx-sdk to use the correct address for multicall3 on zksync, as per https://github.com/mds1/multicall/blob/main/deployments.json#L927
How Has This Been Tested?
Tests
Are there any breaking changes?
Any direct consumers of the
MULTICALL_ADDRESSexport of uniswapx-sdk will have to change to usemulticallAddressOn(chainId). I'm not aware of any codebases using this besides fee-collector, which is what motivated this change.If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title
feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.(Optional) Feedback Focus
[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]
(Optional) Follow Ups
[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]