Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uniswapx-sdk): Add back in relay order reactor addresses #69

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

zhongeric
Copy link
Contributor

PR Scope

Please title your PR according to the following types and scopes following conventional commits:

  • fix(SDK name): will trigger a patch version
  • chore(<type>): will not trigger any release and should be used for internal repo changes
  • <type>(public): will trigger a patch version for non-code changes (e.g. README changes)
  • feat(SDK name): will trigger a minor version
  • feat(breaking): will trigger a major version for a breaking change

Description

In a previous PR #65 , removing the relay order reactor address for other chains caused errors in order service, this PR reverts that change. A TODO would be to refactor how we store addresses currently

How Has This Been Tested?

[e.g. Manually, E2E tests, unit tests, Storybook]

Are there any breaking changes?

[e.g. Type definitions, API definitions]

If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.

(Optional) Feedback Focus

[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]

(Optional) Follow Ups

[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]

@zhongeric zhongeric requested a review from a team as a code owner August 7, 2024 14:48
@graphite-app graphite-app bot requested a review from a team August 7, 2024 14:55
Copy link

graphite-app bot commented Aug 7, 2024

Graphite Automations

"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (08/07/24)

1 assignee was added and 2 reviewers were added to this PR based on 's automation.

@ConjunctiveNormalForm ConjunctiveNormalForm merged commit eab3f3a into main Aug 7, 2024
4 checks passed
Copy link

github-actions bot commented Aug 7, 2024

🎉 This PR is included in version @uniswap/uniswapx-sdk-v2.1.0-beta.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants