feat(router-sdk): support mixed route with v4 route #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsy1218
changed the title
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (09/11/24)1 reviewer was added and 1 assignee was added to this PR based on 's automation. |
ewilz
reviewed
Sep 11, 2024
xrsv
approved these changes
Sep 11, 2024
jsy1218
force-pushed
the
siyujiang/route-266-mixed-routing-with-v4-route-support-on-sdk-level
branch
3 times, most recently
from
c624953
to
fbf212b
Compare
ewilz
reviewed
Sep 12, 2024
ewilz
reviewed
Sep 12, 2024
ewilz
reviewed
Sep 12, 2024
ewilz
reviewed
Sep 12, 2024
ewilz
reviewed
Sep 13, 2024
ewilz
approved these changes
Sep 13, 2024
jsy1218
force-pushed
the
siyujiang/route-266-mixed-routing-with-v4-route-support-on-sdk-level
branch
from
e595dbf
to
ff04722
Compare
cgkol
approved these changes
Sep 13, 2024
snreynolds
pushed a commit
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, if a mixed route contains a v4 pool, we will throw error. Now we will support mixed route with v4 pool.
How Has This Been Tested?
Assert now existing mixed route with v4 pools with encode into expected path.
Are there any breaking changes?
[e.g. Type definitions, API definitions]
No
(Optional) Feedback Focus
No
(Optional) Follow Ups
In future, once we are confident that mixed quoter v2 can work 100% of the time within SOR, then we can remove the else block.