Update eip-1559-gas-price-provider.ts #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this.blocksToConsider needs to be an int, not quoted string in the eth_feeHistory RPC call - I get a {"code": -32602, "message": "Invalid method parameter(s)."} without this
whenmoon
approved these changes
Sep 24, 2021
|
Thanks. I confirmed this works on Infura too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.blocksToConsider needs to be an int, not quoted string in the eth_feeHistory RPC call - I get a {"code": -32602, "message": "Invalid method parameter(s)."} without this
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
32602 - Invalid method parameter(s)
What is the new behavior (if this is a feature change)?
Works as expected
Other information:
JSON_RPC_PROVIDER is Alchemy, Node.js v16.9.1