Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider moving remaining fixedpointextra methods to uniswap/lib #27

Closed
moodysalem opened this issue Jun 23, 2020 · 2 comments · Fixed by #76
Closed

Consider moving remaining fixedpointextra methods to uniswap/lib #27

moodysalem opened this issue Jun 23, 2020 · 2 comments · Fixed by #76
Assignees
@NoahZinsmeister
Labels
refactoring make the code more readable

Comments

@moodysalem
Copy link
Contributor

No description provided.

@moodysalem moodysalem self-assigned this Jun 23, 2020
@moodysalem moodysalem added the refactoring make the code more readable label Jun 23, 2020
@NoahZinsmeister
Copy link
Contributor

right now these methods are: muli, muluq, and divuq

@NoahZinsmeister
Copy link
Contributor

see Uniswap/solidity-lib#5

@NoahZinsmeister NoahZinsmeister changed the title Move fixedpointextra methods to uniswap/lib Consider moving remaining fixedpointextra methods to uniswap/lib Jul 21, 2020
@moodysalem moodysalem removed their assignment Oct 13, 2020
@moodysalem moodysalem mentioned this issue Oct 17, 2020
Merged
0xrelapse pushed a commit to ferumlabs/uni-v3-core that referenced this issue Mar 22, 2024
@moodysalem
remove weth10 (Uniswap#27)
ede9e08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NoahZinsmeister NoahZinsmeister

Labels
refactoring make the code more readable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP - Bump lib Uniswap/v3-core
2 participants
@NoahZinsmeister @moodysalem