-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFTDescriptor: escape quotes #104
Conversation
struct DecimalStringParams { | ||
// significant figures of decimal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier's gone rogue...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think i ran into this once before, look for an issue in the solidity prettier plugin repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, I'm so sorry about this. I just opened a PR that fixes this: prettier-solidity/prettier-plugin-solidity#480 I'll try to have it merged and released today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, Franco, that was so quick!! thank you! cc @fvictorio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be fixed in prettier-plugin-solidity@1.0.0-beta.10
. Let us know if it's not!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yess, that did the trick 💯 happy to be able to throw you weird edgecases as you guys get closer to a stable release 😂
@@ -113,43 +113,35 @@ library NFTDescriptor { | |||
} | |||
|
|||
function formatTokenSymbol(string memory symbol) internal pure returns (string memory) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems this method should be more like escapeQuotes(string) returns (string)
and could use some fuzz testing (it may not work right multibyte characters, not sure)
closes #56