Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: switch chain behavior #195

Merged
merged 6 commits into from
Sep 9, 2022
Merged

fix: switch chain behavior #195

merged 6 commits into from
Sep 9, 2022

Conversation

zzmp
Copy link
Contributor

@zzmp zzmp commented Sep 8, 2022

  • Switch chains without prompting on network provider
  • Prompt chain switch if either token mismatches the current chain
  • Continue to display fetched swaps when disabled

@zzmp zzmp requested a review from JFrankfurt September 8, 2022 19:21
@vercel
Copy link

vercel bot commented Sep 8, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
widgets ✅ Ready (Inspect) Visit Preview Sep 9, 2022 at 4:38PM (UTC)

@vercel vercel bot temporarily deployed to Preview September 8, 2022 19:21 Inactive
@zzmp zzmp mentioned this pull request Sep 8, 2022
Merged
@vercel vercel bot temporarily deployed to Preview September 9, 2022 00:01 Inactive
JFrankfurt
JFrankfurt suggested changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@JFrankfurt JFrankfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine w/ the functionality changes going in as they are, but I think this needs some work to make the code "self-documenting".

@vercel vercel bot temporarily deployed to Preview September 9, 2022 16:36 Inactive
@zzmp zzmp requested a review from JFrankfurt September 9, 2022 16:37
@vercel vercel bot temporarily deployed to Preview September 9, 2022 16:38 Inactive
@zzmp zzmp merged commit 6e27965 into main Sep 9, 2022
@zzmp zzmp deleted the fix-switch branch September 9, 2022 19:33
@github-actions
Copy link

🎉 This PR is included in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JFrankfurt JFrankfurt JFrankfurt approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zzmp @JFrankfurt