-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of complex type constraints #41
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeypospelov
force-pushed
the
sergey/instanceof
branch
2 times, most recently
from
July 20, 2023 12:09
d777277
to
da6b53d
Compare
sergeypospelov
changed the title
WIP: Support of complex type constraints
Support of complex type constraints
Jul 24, 2023
sergeypospelov
force-pushed
the
sergey/instanceof
branch
from
July 24, 2023 14:06
2f8191b
to
8f08dea
Compare
Damtev
requested changes
Jul 25, 2023
usvm-core/src/main/kotlin/org/usvm/constraints/TypeConstraints.kt
Outdated
Show resolved
Hide resolved
usvm-core/src/main/kotlin/org/usvm/constraints/TypeConstraints.kt
Outdated
Show resolved
Hide resolved
usvm-core/src/main/kotlin/org/usvm/constraints/TypeConstraints.kt
Outdated
Show resolved
Hide resolved
dvvrd
requested changes
Jul 25, 2023
Damtev
requested changes
Jul 26, 2023
usvm-core/src/main/kotlin/org/usvm/constraints/TypeConstraints.kt
Outdated
Show resolved
Hide resolved
@Damtev, could you review again? Unresolve conversations if something is unclear. |
Damtev
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dvvrd
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds complex type constraints:
UIsSubtypeExpr
UIsSupertypeExpr
Details
UTypeSolver
Extracted
verify
function to a separated classUTypeSolver
to simplify configuring.Previously, the constraint
(%1 == 42 || %2 <: A)
caused RE, becauseUSolverBase
andUTypeSolver
didn't support propositional variables for type constraints. The PR fixes it in the following way:mkConst
s declarations.UTypeSolver
include the information about interpretedUIsSubtypeExpr
andUIsSupertypeExpr
.UIsSupertypeExpr
Add a special type constraint for expressing the type of the
ref
is supertype of thesubtype
.Now it's unused, but it's necessary for type connections and virtual invokes, which will be added in the future.
Minor
UHeapRef
toUSymbolicHeapRef
UTransformer
UTypeSystem
and related entitiesUTypeRegion
PR TODO: