Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ANSI escape codes with --watch #3884 #4270

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

taneltm
Copy link
Contributor

@taneltm taneltm commented May 7, 2019

Running pm2 list --watch doesn't update the status table properly.

The escape code should be \033, but that doesn't work in strict mode, probably because of that it was changed to \\033 which isn't valid either.

Tests failed

[~] Starting test ./test/e2e/misc/nvm-node-version.sh
######## ✘ Errors in setting interpreters

But that doesn't seem to be related to this change.

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets #3884
License MIT
Doc PR n/a

The escape code should be \033, but that doesn't work in strict mode, probably because of that it was changed to \\033 which isn't valid either.
@CLAassistant
Copy link

CLAassistant commented May 7, 2019

CLA assistant check
All committers have signed the CLA.

@Unitech Unitech merged commit 707389a into Unitech:development Oct 11, 2019
@Unitech
Copy link
Owner

Unitech commented Oct 11, 2019

awesome thanks

inerc pushed a commit to inerc/pm2 that referenced this pull request Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants