Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.5.x: Process.send('ready') does not trigger SIGINT #4376

Merged
merged 1 commit into from
Oct 11, 2019
Merged

3.5.x: Process.send('ready') does not trigger SIGINT #4376

merged 1 commit into from
Oct 11, 2019

Conversation

Goodluckhf
Copy link
Contributor

@Goodluckhf Goodluckhf commented Jul 30, 2019 •
edited
Loading

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #4300,#4271
License MIT

Related to this issues #4300,#4271

I've created branch from 3.5.1 (latest 3.x.x) by that moment

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Goodluckhf
Copy link
Contributor Author

Goodluckhf commented Jul 30, 2019 •
edited
Loading

image
It's kind of weird that test have been broken in the version which i used for developing.
All tests are passing on my PC 🙂
And I looked to other PR's they are also broken
I suppose it because of I fix this for versions 3.5.x. I didn't check for 4.xx

@Goodluckhf Goodluckhf mentioned this pull request Jul 30, 2019
Closed
@knoxcard
Copy link

knoxcard commented Oct 4, 2019

When is this going to be merged?

@Unitech Unitech merged commit 86f0e96 into Unitech:development Oct 11, 2019
@Unitech Unitech mentioned this pull request Oct 11, 2019
Closed
@Unitech
Copy link
Owner

Unitech commented Oct 15, 2019

Available in PM2 4.1.0

npm install pm2@latest -g
pm2 update

inerc pushed a commit to inerc/pm2 that referenced this pull request Feb 11, 2020
@Unitech
Merge pull request Unitech#4376 from Goodluckhf/wait-ready-fix
0df74df 
3.5.x: Process.send('ready') does not trigger SIGINT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Goodluckhf @CLAassistant @knoxcard @Unitech