Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop and delete cron immediately on deletion of a process #4492

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

bvsubhash
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #4485
License MIT

Solves two problems:

  1. Stops and deletes the cron job during the process deletion itself. Soft reload won't be called even in absence of process.
  2. Doesn't restart wrong process in the case where if new process gets spun up and gets same process id assigned to it as well

@Unitech Unitech merged commit 378d443 into Unitech:development Nov 14, 2019
inerc pushed a commit to inerc/pm2 that referenced this pull request Feb 11, 2020
fix: stop and delete cron immediately on deletion of a process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants