Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backward compatibility fix for tarball modules #4767

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

ykolbin
Copy link
Contributor

@ykolbin ykolbin commented Jul 2, 2020

#4593 affected backward compatibility, if someone try to install tarball module without tarball option.

Actually, it contains bad regular expression for following use cases:

  1. Module name with digits (pm install pm2-module-name.tar.gz)
  2. Modules/TAR.js can use Modularizer module_name as module_filepath, but fix for huntr #4593 regular expression is not allowed to specify full path to module (pm install full/path/to/module/pm2-module-name.tar.gz)
  3. Modules/TAR.js can accept URL (pm install http://example.com/pm2/pm2-module-name.tar.gz)
Q A
Bug fix? yes
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR https://github.com/pm2-hive/pm2-hive.github.io/pulls

@ykolbin
Copy link
Contributor Author

ykolbin commented Jul 2, 2020

Workaround: pm install --tarball full/path/to/module/pm2-module-name.tar.gz
@adunkey, do you remember original issue for your fix?

@ykolbin ykolbin closed this Jul 3, 2020
@ykolbin ykolbin reopened this Jul 3, 2020
@ykolbin ykolbin force-pushed the fix_tarball_module_name_v2 branch 2 times, most recently from 1eccc5b to c16829c Compare July 3, 2020 11:05
@ykolbin ykolbin force-pushed the fix_tarball_module_name_v2 branch from c16829c to fd49e10 Compare July 3, 2020 12:07
@Unitech Unitech merged commit 39286ab into Unitech:development Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants