Prevent reloadLogs command from hanging #4782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Previously, when the pm2 reloadLogs command was running as a non-root user, the process will not release and hangs. The reason for the hang is that the forked process never closes because the object is empty and doesn't contain the expected object. This commit checks if an object exists first, before trying to execute methods on it. Related to: Unitech#4781 Co-authored-by: Franck Danard <fdanard@sangoma.com>
|
Hello, Does the CLA need to be signed by me or the responsible party in my company? |
|
If there are no more issues with the CLA, maybe someone can help me on the right direction for this issue? This patch seems to resolve the issue for us, but it may not be the best approach. If you can point me in a direction I should look, it would be helpful. I would love to help contribute if I can to resolve our issue. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the pm2 reloadLogs command was running as a non-root
user, the process will not release and hangs. The reason for the hang
is that the forked process never closes because the object is empty
and doesn't contain the expected object. This commit checks if an
object exists first, before trying to execute methods on it.
Related to: #4781
Co-authored-by: Franck Danard fdanard@sangoma.com