Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed an issue where only one of the two lookdev views would update when changing the default lookdev volume profile. #1529

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Fixed an issue where only one of the two lookdev views would update when changing the default lookdev volume profile. #1529

merged 3 commits into from
Aug 25, 2020

Conversation

JulienIgnace-Unity
Copy link
Collaborator

Purpose of this PR

Fixed an issue where only one of the two lookdev views would update when changing the default lookdev volume profile.
This was caused by the cached hash being common between the N views of the lookdev and thus updating only the first view changing it.

https://fogbugz.unity3d.com/f/cases/1262170/

Testing status

Pretty trivial test with the provided repro steps.

TomasKiniulis
TomasKiniulis approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@TomasKiniulis TomasKiniulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! Made sure that switching volumes, changing existing override and newly added override parameters adjusts both views accordingly.

RSlysz
RSlysz approved these changes Aug 12, 2020
View reviewed changes
Copy link
Collaborator

@RSlysz RSlysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📗

@JulienIgnace-Unity
Merge branch 'HDRP/staging' of https://github.com/Unity-Technologies/…
bed8811 
…Graphics into HDRP/split-lookdev-split-default-volume

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md
@JulienIgnace-Unity JulienIgnace-Unity merged commit 4426bb1 into HDRP/staging Aug 25, 2020
@JulienIgnace-Unity JulienIgnace-Unity deleted the HDRP/split-lookdev-split-default-volume branch August 25, 2020 12:03
sebastienlagarde pushed a commit that referenced this pull request Sep 1, 2020
@JulienIgnace-Unity @sebastienlagarde
Fixed an issue where only one of the two lookdev views would update w…
dc83afb 
…hen changing the default lookdev volume profile. #1529
@sebastienlagarde sebastienlagarde mentioned this pull request Sep 1, 2020
Merged
sebastienlagarde added a commit that referenced this pull request Sep 2, 2020
@sebastienlagarde @FrancescoC-unity
@fredericv-unity3d @alelievr @RSlysz @adrien-de-tocqueville @pastasfuture @JulienIgnace-Unity @JordanL8 @i9neus @jpg-unity
Merge 7.x.x/hd/staging (#1743)
6f5180a 
* Pre warm RT Handle system so that reallocations are reduced.

* Fixed blend distance editing (1248931) #838

* Fix custom pass after post process buffer #1072

* Find the appropriate default frame settings per editor (case 1247631) #1129

* Hdrp/fix hierarchicalbox gizmo symetry and homothety mode ensuring face faces outside #1228

* Remove MSAA debug mode when renderpipeline asset has no MSAA #1289

* Bugfix for HDRenderPipelineAsset getting set to null when running unity in batchmode, resulting in broken builds. (#1696)

Co-authored-by: pastasfuture <nickb@bonfirestudios.com>

* Fix compilation issue when XR is not available #1391

* Fixed an issue where only one of the two lookdev views would update when changing the default lookdev volume profile. #1529

* Added propagating nans doc (#1562)

* Added propagating nans doc

* Added information about HDRP's NanTracker

* GFXGI-237: Force update for static skies when camera type is set to S… #1570

* Fixing the remapping of Min/Max parametrizations values to Amplitude parametrizations values

* Updating UI to match documentation of LayeredLit

* Hdrp/fix/terrain layer parametrization #1678

* Update HDRenderPipeline.LookDev.cs (#1740)

* Added information about HDRP not upgrading particle shaders (#1601)

* Added information about HDRP not upgrading particle shaders

* Update Upgrading-To-HDRP.md

* Update Upgrading-To-HDRP.md

* Changed cog to gear to adhere to style guide rules #1611

* Added build settings setup (#1631)

* Hdrp/docs/shader additions #1580

Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: Nicholas Brancaccio <pastasfuture@gmail.com>
Co-authored-by: pastasfuture <nickb@bonfirestudios.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: Ben Spencer <github@raytracing.co.uk>
Co-authored-by: Jean-Philippe Grenier <jeanphilippe@unity3d.com>
sebastienlagarde added a commit that referenced this pull request Sep 9, 2020
@sebastienlagarde @FrancescoC-unity
@fredericv-unity3d @alelievr @RSlysz @adrien-de-tocqueville @pastasfuture @JulienIgnace-Unity @JordanL8 @i9neus @jpg-unity @fabien-unity
Merge 7.x.x/hd/staging (#1796)
d40dce3 
* Pre warm RT Handle system so that reallocations are reduced.

* Fixed blend distance editing (1248931) #838

* Fix custom pass after post process buffer #1072

* Find the appropriate default frame settings per editor (case 1247631) #1129

* Hdrp/fix hierarchicalbox gizmo symetry and homothety mode ensuring face faces outside #1228

* Remove MSAA debug mode when renderpipeline asset has no MSAA #1289

* Bugfix for HDRenderPipelineAsset getting set to null when running unity in batchmode, resulting in broken builds. (#1696)

Co-authored-by: pastasfuture <nickb@bonfirestudios.com>

* Fix compilation issue when XR is not available #1391

* Fixed an issue where only one of the two lookdev views would update when changing the default lookdev volume profile. #1529

* Added propagating nans doc (#1562)

* Added propagating nans doc

* Added information about HDRP's NanTracker

* GFXGI-237: Force update for static skies when camera type is set to S… #1570

* Fixing the remapping of Min/Max parametrizations values to Amplitude parametrizations values

* Updating UI to match documentation of LayeredLit

* Hdrp/fix/terrain layer parametrization #1678

* Update HDRenderPipeline.LookDev.cs (#1740)

* Added information about HDRP not upgrading particle shaders (#1601)

* Added information about HDRP not upgrading particle shaders

* Update Upgrading-To-HDRP.md

* Update Upgrading-To-HDRP.md

* Changed cog to gear to adhere to style guide rules #1611

* Added build settings setup (#1631)

* Hdrp/docs/shader additions #1580

* Fix XR multipass #1133

* Fix Screen position out of view frustum issues when planar reflection probe is at same camera location #1537

* Update Layered-Lit-Shader #1766

* Fix for assertion on undoing a mod of diffuse profile list with volume profile deleted #1769

* Fixed two issues with sky static lighting. #1775

* [8.x.x backport] Fix issues with history sampling and hw dynamic res #1777

* fixed changelog

* Fix for potentially corrupted refraction result on xbox #1699

Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: Nicholas Brancaccio <pastasfuture@gmail.com>
Co-authored-by: pastasfuture <nickb@bonfirestudios.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: Ben Spencer <github@raytracing.co.uk>
Co-authored-by: Jean-Philippe Grenier <jeanphilippe@unity3d.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
sebastienlagarde pushed a commit that referenced this pull request Nov 16, 2020
@JulienIgnace-Unity @sebastienlagarde
Fixed an issue where only one of the two lookdev views would update w…
5e1289b 
…hen changing the default lookdev volume profile. #1529
sebastienlagarde added a commit that referenced this pull request Nov 16, 2020
@sebastienlagarde @pmavridis
@fabien-unity @JordanL8 @robinb-u3d @adrien-de-tocqueville @FrancescoC-unity @JulienIgnace-Unity @i9neus @jpg-unity
Merge 8.x.x/hd/staging (#2647)
0315ea4 
* Fix warning in HDAdditionalLightData OnValidate #885

* Fix XR multipass #1133

* Update Override-Micro-Shadows.md (#1236)

* Added disclaimer to volumes (#1247)

* Added missing volumes API toc entry (#1259)

* Fix XR Display providers not getting zNear and zFar updated on them. #1269

* Remove MSAA debug mode when renderpipeline asset has no MSAA #1289

* Added menu items doc

* Moved requirements in toc to make it consistent with URP/VFX #1352

* Fix compilation issue when XR is not available #1391

* Fix an issue with dynamic resolution handler in case no OnResolutionChange callback is defined #1403

* Change a multi compile to multi compile local to reduce number of keyword #1444

* Docs quality fixes #1445

* Added enable Volume snippet

* Update Volume-Override-Enable-Override.md

* Update HDCamera.cs

* Fix layer-related error caused by disabling emissive area light mesh #1506

* Make sure sun icon is not clipped in lookdev window #1515

* Fix for LookDev displaying probes as pink spheres #1521

* Fix issue with disc area light editor not updating #1526

* Fixed an issue where only one of the two lookdev views would update when changing the default lookdev volume profile. #1529

* Hdrp/update decal atlas when texture changes #1532

* Fix Screen position out of view frustum issues when planar reflection probe is at same camera location #1537

* Make sure diffusion profile is correct upon its editor reset #1538

* Added propagating nans doc (#1562)

* Added propagating nans doc

* Added information about HDRP's NanTracker

* GFXGI-237: Force update for static skies when camera type is set to S… #1570

* Hdrp/docs/shader additions #1580

* Added information about HDRP not upgrading particle shaders (#1601)

* Added information about HDRP not upgrading particle shaders

* Update Upgrading-To-HDRP.md

* Update Upgrading-To-HDRP.md

* Changed cog to gear to adhere to style guide rules #1611

* Added build settings setup (#1631)

* Fixing the remapping of Min/Max parametrizations values to Amplitude parametrizations values

* Updating UI to match documentation of LayeredLit

* Hdrp/fix/terrain layer parametrization #1678

Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: robinb-u3d <robinb-u3d@users.noreply.github.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: Ben Spencer <github@raytracing.co.uk>
Co-authored-by: Jean-Philippe Grenier <jeanphilippe@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RSlysz RSlysz RSlysz approved these changes

@TomasKiniulis TomasKiniulis TomasKiniulis approved these changes

@sebastienlagarde sebastienlagarde Awaiting requested review from sebastienlagarde

Assignees
No one assigned
Labels
backported-7.x backported-8.x HDRP
Projects
None yet
Milestone
No milestone
4 participants
@JulienIgnace-Unity @RSlysz @TomasKiniulis @sebastienlagarde