Added propagating nans doc #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
JordanL8
requested review from
JulienIgnace-Unity
and removed request for
sebastienlagarde
|
|
||
| If you are unable to fix the source of the NaN/Inf values, [HDRP Cameras](HDRP-Camera.md) include a feature which replaces NaN and Inf values with a black pixel. This stops effects like bloom from propagating NaN/Inf values, but is a fairly resource intensive process. To enable this feature, select a Camera and, in the Inspector, enable the **Stop NaNs** checkbox. Note that you should only enable this feature if you are unable to fix the root cause of the NaN/Inf values. | ||
|
|
||
| ### Finding NaNs and Infs |
There was a problem hiding this comment.
We also have a debug mode just for this in the Debug Window. It should display pixels containing NaNs with a recognizable color.
It's under Rendering -> Fullscreen Debug Mode -> NaN Tracker.
Might be better to mention this first as it's easier for people to use to track if there is actually NaNs on the screen (but then render doc will be more useful to track the actual draw call containing the issue).
JulienIgnace-Unity
requested changes
Aug 24, 2020
JulienIgnace-Unity
approved these changes
Aug 25, 2020
sebastienlagarde
pushed a commit
that referenced
this pull request
Sep 1, 2020
* Added propagating nans doc * Added information about HDRP's NanTracker
Merged
6 tasks
sebastienlagarde
added a commit
that referenced
this pull request
Sep 2, 2020
* Pre warm RT Handle system so that reallocations are reduced. * Fixed blend distance editing (1248931) #838 * Fix custom pass after post process buffer #1072 * Find the appropriate default frame settings per editor (case 1247631) #1129 * Hdrp/fix hierarchicalbox gizmo symetry and homothety mode ensuring face faces outside #1228 * Remove MSAA debug mode when renderpipeline asset has no MSAA #1289 * Bugfix for HDRenderPipelineAsset getting set to null when running unity in batchmode, resulting in broken builds. (#1696) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> * Fix compilation issue when XR is not available #1391 * Fixed an issue where only one of the two lookdev views would update when changing the default lookdev volume profile. #1529 * Added propagating nans doc (#1562) * Added propagating nans doc * Added information about HDRP's NanTracker * GFXGI-237: Force update for static skies when camera type is set to S… #1570 * Fixing the remapping of Min/Max parametrizations values to Amplitude parametrizations values * Updating UI to match documentation of LayeredLit * Hdrp/fix/terrain layer parametrization #1678 * Update HDRenderPipeline.LookDev.cs (#1740) * Added information about HDRP not upgrading particle shaders (#1601) * Added information about HDRP not upgrading particle shaders * Update Upgrading-To-HDRP.md * Update Upgrading-To-HDRP.md * Changed cog to gear to adhere to style guide rules #1611 * Added build settings setup (#1631) * Hdrp/docs/shader additions #1580 Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Nicholas Brancaccio <pastasfuture@gmail.com> Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: Ben Spencer <github@raytracing.co.uk> Co-authored-by: Jean-Philippe Grenier <jeanphilippe@unity3d.com>
sebastienlagarde
added a commit
that referenced
this pull request
Sep 9, 2020
* Pre warm RT Handle system so that reallocations are reduced. * Fixed blend distance editing (1248931) #838 * Fix custom pass after post process buffer #1072 * Find the appropriate default frame settings per editor (case 1247631) #1129 * Hdrp/fix hierarchicalbox gizmo symetry and homothety mode ensuring face faces outside #1228 * Remove MSAA debug mode when renderpipeline asset has no MSAA #1289 * Bugfix for HDRenderPipelineAsset getting set to null when running unity in batchmode, resulting in broken builds. (#1696) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> * Fix compilation issue when XR is not available #1391 * Fixed an issue where only one of the two lookdev views would update when changing the default lookdev volume profile. #1529 * Added propagating nans doc (#1562) * Added propagating nans doc * Added information about HDRP's NanTracker * GFXGI-237: Force update for static skies when camera type is set to S… #1570 * Fixing the remapping of Min/Max parametrizations values to Amplitude parametrizations values * Updating UI to match documentation of LayeredLit * Hdrp/fix/terrain layer parametrization #1678 * Update HDRenderPipeline.LookDev.cs (#1740) * Added information about HDRP not upgrading particle shaders (#1601) * Added information about HDRP not upgrading particle shaders * Update Upgrading-To-HDRP.md * Update Upgrading-To-HDRP.md * Changed cog to gear to adhere to style guide rules #1611 * Added build settings setup (#1631) * Hdrp/docs/shader additions #1580 * Fix XR multipass #1133 * Fix Screen position out of view frustum issues when planar reflection probe is at same camera location #1537 * Update Layered-Lit-Shader #1766 * Fix for assertion on undoing a mod of diffuse profile list with volume profile deleted #1769 * Fixed two issues with sky static lighting. #1775 * [8.x.x backport] Fix issues with history sampling and hw dynamic res #1777 * fixed changelog * Fix for potentially corrupted refraction result on xbox #1699 Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Nicholas Brancaccio <pastasfuture@gmail.com> Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: Ben Spencer <github@raytracing.co.uk> Co-authored-by: Jean-Philippe Grenier <jeanphilippe@unity3d.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com>
sebastienlagarde
pushed a commit
that referenced
this pull request
Nov 16, 2020
* Added propagating nans doc * Added information about HDRP's NanTracker
Merged
sebastienlagarde
added a commit
that referenced
this pull request
Nov 16, 2020
* Fix warning in HDAdditionalLightData OnValidate #885 * Fix XR multipass #1133 * Update Override-Micro-Shadows.md (#1236) * Added disclaimer to volumes (#1247) * Added missing volumes API toc entry (#1259) * Fix XR Display providers not getting zNear and zFar updated on them. #1269 * Remove MSAA debug mode when renderpipeline asset has no MSAA #1289 * Added menu items doc * Moved requirements in toc to make it consistent with URP/VFX #1352 * Fix compilation issue when XR is not available #1391 * Fix an issue with dynamic resolution handler in case no OnResolutionChange callback is defined #1403 * Change a multi compile to multi compile local to reduce number of keyword #1444 * Docs quality fixes #1445 * Added enable Volume snippet * Update Volume-Override-Enable-Override.md * Update HDCamera.cs * Fix layer-related error caused by disabling emissive area light mesh #1506 * Make sure sun icon is not clipped in lookdev window #1515 * Fix for LookDev displaying probes as pink spheres #1521 * Fix issue with disc area light editor not updating #1526 * Fixed an issue where only one of the two lookdev views would update when changing the default lookdev volume profile. #1529 * Hdrp/update decal atlas when texture changes #1532 * Fix Screen position out of view frustum issues when planar reflection probe is at same camera location #1537 * Make sure diffusion profile is correct upon its editor reset #1538 * Added propagating nans doc (#1562) * Added propagating nans doc * Added information about HDRP's NanTracker * GFXGI-237: Force update for static skies when camera type is set to S… #1570 * Hdrp/docs/shader additions #1580 * Added information about HDRP not upgrading particle shaders (#1601) * Added information about HDRP not upgrading particle shaders * Update Upgrading-To-HDRP.md * Update Upgrading-To-HDRP.md * Changed cog to gear to adhere to style guide rules #1611 * Added build settings setup (#1631) * Fixing the remapping of Min/Max parametrizations values to Amplitude parametrizations values * Updating UI to match documentation of LayeredLit * Hdrp/fix/terrain layer parametrization #1678 Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: robinb-u3d <robinb-u3d@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Ben Spencer <github@raytracing.co.uk> Co-authored-by: Jean-Philippe Grenier <jeanphilippe@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Adds propagating NaNs doc and supporting images.