Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug related to light cluster invalidation #1558

Merged
merged 3 commits into from
Aug 25, 2020

Conversation

anisunity
Copy link
Contributor

@anisunity anisunity commented Aug 10, 2020

lightClusterBug

The cause of the bug is complex, here is the repro. Ping me to explain it.

Purpose of this PR

DXR tests were ran locally and they are green

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

Copy link
Contributor

@remi-chapelain remi-chapelain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked with the DXR tests and some custom project that issue is fixed.
Also checked if nothing weird happened if you disable / enable light cluster volume override
✔️

@JulienIgnace-Unity JulienIgnace-Unity merged commit 603b6c2 into HDRP/staging Aug 25, 2020
@JulienIgnace-Unity JulienIgnace-Unity deleted the HDRP/FixLightClusterResize branch August 25, 2020 15:19
@sebastienlagarde sebastienlagarde mentioned this pull request Sep 3, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants