Hdrp/deferred shadow quality multi compile #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reopening this as migration did not happen |
| // Since we use slope-scale bias, the constant bias is for now set as a small fixed value | ||
| #define FIXED_UNIFORM_BIAS (1.0f / 65536.0f) | ||
|
|
||
| // We can't use multi_compile for compute shaders so we force the shadow algorithm |
There was a problem hiding this comment.
remove this comment :)
sebastienlagarde
approved these changes
Apr 8, 2020
|
@FrancescoC-unity . Various thing:
For QA:
|
|
Note: build player time will increase but it should still faiirly manageable compare to lit.shader, and Juho is working on the stripping part. |
…ompile # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md # com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/Deferred.compute # com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs
FrancescoC-unity
commented
Apr 8, 2020
|
|
||
| In the High Definition Render Pipeline (HDRP), some features work differently between major versions of Unity. This document helps you upgrade HDRP from Unity 2020.1 to 2020.2. | ||
|
|
||
| ## Shadows |
There was a problem hiding this comment.
Note, I named this generically Shadows as when the shadow caching rewrite lands I might need to add something here.
JulienIgnace-Unity
approved these changes
Apr 15, 2020
|
|
||
| #pragma multi_compile _ SHADOWS_SHADOWMASK | ||
|
|
||
| #pragma multi_compile SHADOW_LOW SHADOW_MEDIUM SHADOW_HIGH |
There was a problem hiding this comment.
you need to do this also for deferred.shader and tiledeferred.shader
There was a problem hiding this comment.
Ha! Yes I always forget about those two. Will do!
|
For QA: Please test also with deferredTile and deferred if thing work with shadow. |
TomasKiniulis
approved these changes
Apr 21, 2020
There was a problem hiding this comment.
No issues found.�
- Made sure Forward Only Shadow Filtering still works
- In "Deferred Mode" and "Both" Lit Shader Modes checked that filtering quality low/medium/high correctly filters Directional Light, Point Light, Spot Light shadows in editor and player with "Deferred Tile" mode enabled and disabled
- Checked Shadowmask and Distanceshadowmask still works
- Checked Lighting Debug Modes
- Checked that Light Loop Debug, "Compute Light Evalution", "Compute Light Variants", "Compute Material Variants" does not cause any visual issues.
This was referenced Apr 24, 2020
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/6328