2.0 verified to main #5385
Merged
2.0 verified to main #5385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* collecting latest step as a stat * adding a list of hidden_keys to TB summarywriter to hide unnecessary stats from user * fixing precommit * formating * defined the property types * moving custom defaults to get_default_stats_writers * new test for TensorboardWriter.hidden_keys * improved testing * explicit None evaluation Co-authored-by: Ervin T. <ervin@unity3d.com> * make hidden_keys optional Co-authored-by: Ervin T. <ervin@unity3d.com> * adding optional argument * lowering the training threshold to 0.8 on test_var_len_obs_and_goal_poca * Update pytest.yml * Do not merge! droping pytest 3.9 job * -add back pytest -format imports and comments * back to default threshold for test_var_len_obs_and_goal_poca Co-authored-by: mahon94 <maryam.honari@unity3d.com> Co-authored-by: Ervin T. <ervin@unity3d.com> Co-authored-by: mahon94 <maryam.honari@unity3d.com> Co-authored-by: Ervin T. <ervin@unity3d.com>
…) (#5296) * Add strict check to settings.py * Remove warning from trainer factory, add test * Add changelog * Fix test * Update changelog * Remove strict CLI options * Remove strict option, rename, make strict default * Remove newline * Update comments * Set default dict to actually default to a default dict * Fix tests * Fix tests again * Default trainer dict to requiring all fields * Fix settings typing * Use logger * Add default_settings to error (cherry picked from commit 86a4070)
* list removed APIs with replacements * fixes
Co-authored-by: Chris Elion <chris.elion@unity3d.com>
chriselion
commented
May 24, 2021
surfnerd
approved these changes
May 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Make sure everything from 2.0-verified makes it back to main. The main changes are: