-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main fix test error + upd #1142
Conversation
remove tmdb mocks added get series IMDbID from tmdb as omdb seems to give wrong value
update deps
@SurfaceS |
on my code :
So if it take the mocks url (I name it local.themoviedb.org), it mean TMDB_API_KEY is null or 'foo'. |
(see Automattic/mongoose#11861) set MovieDb baseUrl to undefined as null is a value
Concerning the PR : The error in the check Concerning the api : The api is indexed on imdb id's, but sometimes it is only tmdb id specially for series. I'll back on another PR about that. |
We can probably just remove OMDb. Unfortunately we found it before TMDB. If we had found TMDB first, we probably wouldn't have added OMDb. |
Nice fixes thanks! |
fix error :
Seems that tmdb has no apikey set -> result null -> omdb fetch.
I put mocks on tmdb and code related to it (key provided = real fetch, no key or 'foo' key = mocks).
Omdb data seems to give a wrong series IMDbID (give episode IMDbID = series IMDbID).
I put some code to get series IMDbID from tmdb to temp fix that.
Updated the mocks with value given by the omdb server (with errored series IMDbID).
update yarn.
update deps.