Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests improvement #206

Merged
merged 38 commits into from
Oct 19, 2021
Merged

Integration tests improvement #206

merged 38 commits into from
Oct 19, 2021

Conversation

livanov93
Copy link
Contributor

@livanov93 livanov93 commented Oct 14, 2021 •
edited
Loading

Closes #51

@livanov93 livanov93 mentioned this pull request Oct 14, 2021
Closed
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021 •
edited
Loading

Codecov Report

Merging #206 (3c0d121) into main (1b121b7) will decrease coverage by 0.35%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #206      +/-   ##
========================================
- Coverage   3.59%   3.23%   -0.36%     
========================================
  Files         13      13              
  Lines        947    1050     +103     
  Branches     152     152              
========================================
  Hits          34      34              
- Misses       843     946     +103     
  Partials      70      70
Flag Coverage Δ
unittests 3.23% <0.00%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ur_controllers/force_torque_sensor_broadcaster.hpp 0.00% <ø> (ø)
...controllers/scaled_joint_trajectory_controller.hpp 0.00% <0.00%> (ø)
...ontrollers/src/force_torque_sensor_broadcaster.cpp 0.00% <0.00%> (ø)
ur_controllers/src/gpio_controller.cpp 0.00% <0.00%> (ø)
...rollers/src/scaled_joint_trajectory_controller.cpp 0.00% <0.00%> (ø)
...ontrollers/src/speed_scaling_state_broadcaster.cpp 0.00% <0.00%> (ø)
ur_robot_driver/src/hardware_interface.cpp 0.00% <0.00%> (ø)
ur_robot_driver/src/ur_ros2_control_node.cpp 0.00% <0.00%> (ø)
...ver/include/ur_robot_driver/hardware_interface.hpp

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f07034...3c0d121. Read the comment docs.

@livanov93 livanov93 force-pushed the livanov/integration-tests branch 2 times, most recently from 3c0d121 to 6f9cf8f Compare October 19, 2021 14:23
@livanov93
Add separate control node.
c285a25
@livanov93
Move async tasks to separate thread.
8606988
@livanov93
Update pacakge dependencies.
976d8d8
@livanov93
Parametrize starting dashboard client and state of loaded controller.
eafdd69
@livanov93
Cpp formatting.
b2d28d7
@livanov93
Add script for pinging dashboard client.
1f4b1c5
@livanov93
Fix pre-commit.
589dca1
@livanov93
One semi-binary file.
74df6ef
@livanov93
Remove tests from binary and coverage build.
33c7ce5
@livanov93
Add initialized state interface.
f63f090
@livanov93
Revert workflows to main branch.
3843b42
@livanov93
Finalize tests with trajectory execution.
eda8a71
@livanov93
Revert tests to separated ci configs.
a7598ce
@livanov93
Rename initailized flag interface.
04d0419
@livanov93
Enable dashboard client in second test.
f69092d
@livanov93
Fix binary build steps.
ddd606c
@livanov93
Adapt semi-binary and binary builds. Exclude tests from binary and co…
557553f 
…verage.
@livanov93
Remove dashboard launch form test 2.
b7205c4
@livanov93
Test with afterscript.
dc7c35a
@livanov93
Different node names.
a3fc05f
@livanov93
Remove stopping step.
ae5106f
@livanov93
Wait for everything to come up on the network.
87bbd61
@livanov93
Sleep 1 sec on init.
4eb7e58
@livanov93
Test old ci with max parallel 1.
da7e9cc
@livanov93
Set testing to only semi-binaries.
14204a8
@livanov93 livanov93 self-assigned this Oct 19, 2021
destogl
destogl approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge when you get CI green

@destogl destogl merged commit 621f2ec into main Oct 19, 2021
@destogl destogl deleted the livanov/integration-tests branch October 19, 2021 19:54
urmahp added a commit to urmahp/Universal_Robots_ROS2_Driver that referenced this pull request May 6, 2022
@urmahp
Async tasks to seperate thread and initialized state interface (Backp…
2d1c7a8 
…ort parts of UniversalRobots#206)

This will prevent the driver from crashing.
@urmahp urmahp mentioned this pull request May 6, 2022
Merged
fmauch pushed a commit that referenced this pull request May 6, 2022
@urmahp
Async tasks to seperate thread and initialized state interface (Backp…
286fc27 
…ort parts of #206) (#372)

This will prevent the driver from crashing.
fmauch added a commit that referenced this pull request May 10, 2022
@fmauch @urmahp
Foxy controller stopper (#324)
b085d50 
* Added controller stopper node (Backport #309)
* Add state interface to ur_description
* Async tasks to seperate thread and initialized state interface (Backport parts of #206) (#372)
* Add system_interface initialized

Co-authored-by: Mads Holm Peters <79145214+urmahp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@destogl destogl destogl approved these changes

Assignees

@livanov93 livanov93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration test with simulated UR
3 participants
@livanov93 @codecov-commenter @destogl