Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving show subtypes into MyRadio, part 4 - API in myradio-go #48

Merged
merged 2 commits into from
Nov 20, 2019

Conversation

markspolakovs
Copy link
Member

@markspolakovs markspolakovs commented Nov 17, 2019

This is a big project, comprised of several PRs. See here for the plan (internal only). This PR is a continuation of UniversityRadioYork/MyRadio#818

In this PR, the fields for show and season subtypes are added to myradio-go. The next phase will be to have 2016-site use them.

This PR depends on UniversityRadioYork/MyRadio#824 in MyRadio.

@markspolakovs markspolakovs changed the title WIP: Moving show subtypes into MyRadio, part 2 - API WIP: Moving show subtypes into MyRadio, part 3 (originally 4?) - API Nov 17, 2019
@coveralls
Copy link

coveralls commented Nov 17, 2019

Coverage Status

Coverage decreased (-0.1%) to 21.307% when pulling 4db8b5b on markspolakovs-subtypes into e1b02be on master.

@markspolakovs
Copy link
Member Author

This is ready to merge once UniversityRadioYork/MyRadio#824 is merged into MyRadio.

@markspolakovs markspolakovs marked this pull request as ready for review November 18, 2019 14:12
@markspolakovs markspolakovs changed the title WIP: Moving show subtypes into MyRadio, part 3 (originally 4?) - API WIP: Moving show subtypes into MyRadio, part 4 - API in myradio-go Nov 18, 2019
@markspolakovs
Copy link
Member Author

The API is live in dev and should go live in prod later tonight, so this is ready for testing.

@markspolakovs markspolakovs changed the title WIP: Moving show subtypes into MyRadio, part 4 - API in myradio-go Moving show subtypes into MyRadio, part 4 - API in myradio-go Nov 20, 2019
Copy link
Contributor

@Skwunk Skwunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants