fix: provider initialization #169
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| import React from 'react'; | ||
| import { render, screen, waitFor } from '@testing-library/react'; | ||
| import useFlagsStatus from './useFlagsStatus'; | ||
| import FlagProvider from './FlagProvider'; | ||
| import { UnleashClient } from 'unleash-proxy-client'; | ||
|
|
||
| const TestComponent = () => { | ||
| const { flagsReady } = useFlagsStatus(); | ||
|
|
||
| return <div>{flagsReady ? 'flagsReady' : 'loading'}</div>; | ||
| }; | ||
|
|
||
| const ErrorTestComponent = () => { | ||
| const { flagsError } = useFlagsStatus(); | ||
|
|
||
| return <div>{flagsError ? 'flagsError' : 'no issue'}</div>; | ||
| }; | ||
|
|
||
|
|
||
| const mockClient = { | ||
| on: vi.fn(), | ||
| off: vi.fn(), | ||
| start: vi.fn(), | ||
| stop: vi.fn(), | ||
| updateContext: vi.fn(), | ||
| isEnabled: vi.fn(), | ||
| getVariant: vi.fn(), | ||
| isReady: vi.fn(), | ||
| } as unknown as UnleashClient; | ||
|
|
||
| test('should initialize', async () => { | ||
| const onEventHandler = (event: string, callback: () => void) => { | ||
| if (event === 'ready') { | ||
| callback(); | ||
| } | ||
| }; | ||
|
|
||
| mockClient.on = onEventHandler as typeof mockClient.on; | ||
|
|
||
| const ui = ( | ||
| <FlagProvider unleashClient={mockClient}> | ||
| <TestComponent /> | ||
| </FlagProvider> | ||
| ); | ||
|
|
||
| render(ui); | ||
|
|
||
| await waitFor(() => { | ||
| expect(screen.queryByText('flagsReady')).toBeInTheDocument(); | ||
| }); | ||
| }); | ||
|
|
||
| // https://github.com/Unleash/proxy-client-react/issues/168 | ||
| test('should start when already initialized client is passed', async () => { | ||
| const client = new UnleashClient({ | ||
| url: 'http://localhost:4242/api', | ||
| fetch: async () => | ||
| new Promise((resolve) => { | ||
| setTimeout(() => | ||
| resolve({ | ||
| status: 200, | ||
| ok: true, | ||
| json: async () => ({ | ||
| toggles: [], | ||
| }), | ||
| headers: new Headers(), | ||
| }) | ||
| ); | ||
| }), | ||
| clientKey: '123', | ||
| appName: 'test', | ||
| }); | ||
| await client.start(); | ||
| expect(client.isReady()).toBe(true); | ||
|
|
||
| const ui = ( | ||
| <FlagProvider unleashClient={client}> | ||
| <TestComponent /> | ||
| </FlagProvider> | ||
| ); | ||
|
|
||
| render(ui); | ||
|
|
||
| await waitFor(() => { | ||
| expect(screen.queryByText('flagsReady')).toBeInTheDocument(); | ||
| }); | ||
| }); | ||
|
|
||
| test('should handle client errors', async () => { | ||
| const consoleError = vi.spyOn(console, 'error').mockImplementation(() => {}); | ||
|
|
||
| const client = new UnleashClient({ | ||
| url: 'http://localhost:4242/api', | ||
| fetch: async () => { | ||
| throw new Error('test error'); | ||
| }, | ||
| clientKey: '123', | ||
| appName: 'test', | ||
| }); | ||
|
|
||
| await client.start(); | ||
|
|
||
| const ui = ( | ||
| <FlagProvider unleashClient={client}> | ||
| <ErrorTestComponent /> | ||
| </FlagProvider> | ||
| ); | ||
|
|
||
| render(ui); | ||
|
|
||
| await waitFor(() => { | ||
| expect(screen.queryByText('flagsError')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| expect(consoleError).toHaveBeenCalledWith( | ||
| 'Unleash: unable to fetch feature toggles', | ||
| expect.any(Error) | ||
| ); | ||
| consoleError.mockRestore(); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this the only significant line here? Why do we need these other changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's about adding the ability to pass initialized client. Error state is also needed to make sure state kept in React SDK is matching the one from initialized client