Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategy for strategies #18

Closed
Andersos opened this issue Feb 19, 2015 · 4 comments
Closed

Strategy for strategies #18

Andersos opened this issue Feb 19, 2015 · 4 comments

Comments

@Andersos
Copy link
Contributor

Unleash has gotten some pull requests to the Finn client and it is good that people want to use the service. I just want to raise a concern.

Right now this version has the following strategies:

  • DefaultStrategy
  • UnknownStrategy

Finn client has the following strategies:

  • ActiveForUserWithIdStrategy
  • BetaUserStrategy
  • ByHostNameStrategy
  • GradualRolloutRandomStrategy
  • RemoteAddrStrategy

Should we not move more of the strategies from the Finn client over to the open source one?

I also suggest that we add a markdown file that describes the strategies with example use cases.

@ivarconr
Copy link
Member

This is exactly what we must plan for. Can you organize a short meeting to
let us to discuss this?
On 19 Feb 2015 13:04, "Anders Olsen Sandvik" notifications@github.com
wrote:

Unleash has gotten some pull requests to the Finn client and it is good
that people want to use the service. I just want to raise a concern.

Right now this version has the following strategies:

  • DefaultStrategy
  • UnknownStrategy

Finn client has the following strategies:

  • ActiveForUserWithIdStrategy
  • BetaUserStrategy
  • ByHostNameStrategy
  • GradualRolloutRandomStrategy
  • RemoteAddrStrategy

Should we not move more of the strategies from the Finn client over to the
open source one?

I also suggest that we add a markdown file that describes the strategies
with example use cases.


Reply to this email directly or view it on GitHub
#18.

@Andersos
Copy link
Contributor Author

Sounds like a good idea. We should also see if we could put other issues on the agenda like "User authentication" Unleash/unleash#33 and "Integration tests" Unleash/unleash#32

@Andersos
Copy link
Contributor Author

Meeting scheduled for wednesday 25. februar 2015 12:00-13:00.

@Andersos
Copy link
Contributor Author

Some notes from the meeting

Unleash status

Many have started using Unleash.
@ivarconr has presented Unleash and Feature Toggles on the Architecture summit here and Smidig 2014 here.

We will try to write something on the tech blog about Unleash.

I will try and do a write-up of how to setup a local database on Mac.
Pg_vertualenv is working fine on Linux. Do we need to document how to do this?
Maybe @eirslett can come with some pointer about how to run Unleash locally on Windows.

User authentication

You should always be able to turn on or off toggles even if the authentication provider is down.
Ideally everyone that dose a change need to be logged by name.
We will investigate using basic auth and having Crowd as the user provider.

Strategy for strategies

It’s a good idea to first implement the strategies in the Finn client and later move them to the Open Source client when they are mature.
The idea is to deprecate good strategies in the Finn client and move them over to the this repo.

Integration tests

For now we are pleased with the amount of tests and will this issue for now
Unleash/unleash#32

Other

We are looking into making a Node client for Unleash. @ivarconr is leading the push for this.

ivarconr pushed a commit that referenced this issue Feb 20, 2020
ivarconr pushed a commit that referenced this issue Feb 20, 2020
ivarconr pushed a commit that referenced this issue Feb 20, 2020
There is an example in eventRepositorySpec on how to listen on events.
ivarconr added a commit that referenced this issue Feb 20, 2020
ivarconr added a commit that referenced this issue Feb 20, 2020
Also introduced mockery to mock db-access. Here we probably
need better modularisation and/or better dependecy management
(injecting of deps?).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants