feat: Obey HTTP Status codes from upstream. #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriswk
commented
Nov 7, 2023
| @@ -28,6 +38,7 @@ public UnleashMetricServiceImpl( | |||
| this.started = LocalDateTime.now(ZoneId.of("UTC")); | |||
| this.unleashConfig = unleashConfig; | |||
| this.metricSender = metricSender; | |||
| this.maxInterval = Integer.max(20, 300 / Integer.max(Long.valueOf(unleashConfig.getSendMetricsInterval()).intValue(), 1)); | |||
There was a problem hiding this comment.
Happy to discuss this, our goal was that the max should equal 300 seconds at most. because 5 minute interval seems to be enough. I realize the metric sending could be bigger. Suggestions?
Previously we have treated any status code as equal. This PR changes that to allow 429 and 50x status codes to incrementally increase the interval between each time we call. And then gradually decrease once it starts succeeding. I'm a bit worried about the metrics here, because we drop the metric bucket on the floor if we don't get a 20x back from the server.
chriswk
force-pushed
the
feat/handleBackoffs
branch
from
8f5d190
to
65648c2
Compare
I agree this is a concern but I think it needs to be solved in a separate PR. Other SDKs will preserve the metrics and send them on the next interval. |
src/main/java/io/getunleash/metric/UnleashMetricServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/io/getunleash/metric/UnleashMetricServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/io/getunleash/metric/UnleashMetricServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/io/getunleash/metric/UnleashMetricServiceImpl.java
Outdated
Show resolved
Hide resolved
Comment on lines
+62
to
+70
| assertThat(testSubscriber.togglesFetchedCounter) | ||
| .isEqualTo( | ||
| 2); // Server successfully returns, we call synchronous fetch and schedule | ||
| // once, so 2 calls. | ||
| assertThat(testSubscriber.status).isEqualTo(CHANGED); | ||
| assertThat(testSubscriber.toggleEvaluatedCounter).isEqualTo(3); | ||
| assertThat(testSubscriber.toggleName).isEqualTo("myFeature"); | ||
| assertThat(testSubscriber.toggleEnabled).isFalse(); | ||
| assertThat(testSubscriber.errors).hasSize(2); | ||
| assertThat(testSubscriber.errors).isEmpty(); |
There was a problem hiding this comment.
Yes, this looks better 👍
Co-authored-by: Gastón Fournier <gaston@getunleash.io>
Co-authored-by: Gastón Fournier <gaston@getunleash.io>
Co-authored-by: Gastón Fournier <gaston@getunleash.io>
gastonfournier
approved these changes
Nov 8, 2023
Handled with adding the throttler class. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we have treated any status code as equal. This PR changes that to allow 429 and 50x status codes to incrementally increase the interval between each time we call. And then gradually decrease once it starts succeeding.
Discussion points