adding IP range support to remoteAddress #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarconr
reviewed
Nov 17, 2017
| return true; | ||
| } | ||
| } | ||
| if (range === context.remoteAddress) { |
There was a problem hiding this comment.
Minor: Maybe this should the the first if statement. Feels like this could be faster than the range check?
|
Awesome 🔥 . Range-support has been on my wishlist for a while. We should port it to the other client implementations as well. I can release this as |
1 similar comment
This was referenced Nov 17, 2017
|
released as 2.3.1 (https://www.npmjs.com/package/unleash-client) |
ivarconr
pushed a commit
to Unleash/unleash-client-java
that referenced
this pull request
Jun 18, 2019
…#79) The `IpAddressMatcher` class has been taken from Spring Security 5.1.5.RELEASE (also Apache 2 licensed). Source: https://github.com/spring-projects/spring-security/blob/5.1.5.RELEASE/web/src/main/java/org/springframework/security/web/util/matcher/IpAddressMatcher.java Refs Unleash/unleash-client-node#58 Closes #47
ivarconr
pushed a commit
to Unleash/unleash-client-java
that referenced
this pull request
Feb 20, 2020
…#79) The `IpAddressMatcher` class has been taken from Spring Security 5.1.5.RELEASE (also Apache 2 licensed). Source: https://github.com/spring-projects/spring-security/blob/5.1.5.RELEASE/web/src/main/java/org/springframework/security/web/util/matcher/IpAddressMatcher.java Refs Unleash/unleash-client-node#58 Closes #47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a gazilion IPs manually is somewhat of a pain, therefor adding support for IPv4 ranges would really make things easier.
This PR uses the ip module to validate the ranges. I have not updated the docs on this as I wasn't sure if that should go into the PR.