Feat: Support more constraint operators #47
Conversation
…erted' option was set to true
| 'contextName' => 'email', | ||
| 'operator' => ConstraintOperator::STRING_STARTS_WITH, | ||
| 'inverted' => true, | ||
| // missing 'value' and 'values' and 'inverted' set to true |
| protected function convert(string $number): int|float | ||
| { | ||
| if (str_contains($number, '.')) { | ||
| return (float) $number; |
There was a problem hiding this comment.
nice, I will add a float test to the specifications also.
| { | ||
| assert(is_string($searchInValue)); | ||
|
|
||
| return str_ends_with($searchInValue, $currentValue); |
There was a problem hiding this comment.
Is str_ends_with supported in PHP 7.2+, or is it only PHP 8.0?
There was a problem hiding this comment.
There was a problem hiding this comment.
8.0, but this repo contains a downgrader which downgrades the code to multiple version, it gets automatically changed to something suitable for each version during deploy, see for example here for version downgraded to php 7.4.
There was a problem hiding this comment.
And here you can see one of the str_* functions downgraded:
There was a problem hiding this comment.
This is nice. Thanks for explaining 👍🏼
| { | ||
| assert(is_string($searchInValue)); | ||
|
|
||
| return str_starts_with($currentValue, $searchInValue); |
There was a problem hiding this comment.
Explained in previous comments, gets downgraded to suitable expression for each version.
| { | ||
| assert(is_string($searchInValue)); | ||
|
|
||
| return str_contains($currentValue, $searchInValue); |
|
As mentioned before, it gets downgraded for each version, that's why it's kinda easy to support older versions without sacrificing the features of new versions. |
closes #42
Before merging the reference to client-specifications repository should be put back to the
mainbranch.