Allow the client to shutdown in a clean way #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 131
💛 - Coveralls |
rarruda
force-pushed
the
feature/shutdown_client
branch
from
fa06ce8
to
a7b4fb8
Compare
rarruda
commented
Jan 16, 2019
lib/unleash/toggle_fetcher.rb
Outdated
| @@ -38,7 +35,7 @@ def toggles | |||
| end | |||
|
|
|||
| # rename to refresh_from_server! ?? | |||
| # TODO: should simplify by moving uri / http initialization to class initialization | |||
| # TODO: should simplify by moving uri / http initialization to elsewhere | |||
rarruda
force-pushed
the
feature/shutdown_client
branch
2 times, most recently
from
4c3760c
to
9328c5a
Compare
- ToggleFetcher updates the backup client in an atomic operation - Improved locking in ToggleFetcher when saving to disk - Keep track of threads in ScheduledExecutor - Added unit tests for ScheduledExecutor - Improved documentation
rarruda
force-pushed
the
feature/shutdown_client
branch
from
9328c5a
to
23e5740
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.