fix: Only replace projects covered by token #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if the update was empty, we assumed we needed to replace all stored features. This is not the case. We only need to remove the projects that are connected to the token we're using for the merge. In addition, debug output on `/internal-backstage/tokens` now includes how many features was received in the update
chriswk
requested review from
nunogois,
thomasheartman and
sighphyre
and removed request for
thomasheartman
nunogois
reviewed
May 22, 2024
| }) | ||
| .cloned() | ||
| .collect(); | ||
| to_keep.extend(updated.iter().cloned()); |
There was a problem hiding this comment.
I'm assuming that, in case updated is empty, this will act as:
to_keep.extend([]) effectively returning the existing to_keep without any changes.
There was a problem hiding this comment.
yup, to_keep.extend will keep what's in to_keep, but add from updated, and since we've already removed all toggles from to_keep that matches one of the projects this token has access to, we won't have to worry about duplicates.
sighphyre
reviewed
May 22, 2024
sighphyre
approved these changes
May 22, 2024
chriswk
deleted the
fix/unrelatedTokensShouldNotInterfereWithOtherProjects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the update was empty, we assumed we needed to replace all stored features. This is not the case. We only need to remove the projects that are connected to the token we're using for the merge.
In addition, debug output on
/internal-backstage/tokensnow includes how many features was received in the update