Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade node sdk to support dependent features #153

Merged
merged 1 commit into from
Oct 16, 2023
Merged

feat: upgrade node sdk to support dependent features #153

merged 1 commit into from
Oct 16, 2023

Conversation

kwasniew
Copy link
Contributor

About the changes

  • upgraded node SDK to support dependent features
  • upgrading own version since new capability is available after upgrading node SDK

Important files

Discussion points

FredrikOseberg
FredrikOseberg approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. On another note, I think we are way past 0.18.0 on this package. Should have been a stable 1.0.0 a long time ago.

@kwasniew
Copy link
Contributor Author

@FredrikOseberg the question is when should we do the cutoff :)

@kwasniew kwasniew merged commit 3eb505b into main Oct 16, 2023
4 checks passed
@kwasniew kwasniew deleted the version-bump-dependent-features branch October 16, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredrikOseberg FredrikOseberg FredrikOseberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwasniew @FredrikOseberg