Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default session id #155

Merged
merged 2 commits into from
Oct 18, 2023
Merged

feat: default session id #155

merged 2 commits into from
Oct 18, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Oct 18, 2023

About the changes

What problem are we solving?

  • enabled info and variant info in the same feature have to be consistent when stickiness is set to default
  • also we want to have consistency between parent and child features

Solution:

  • if the user didn't provide sessionId, generate one one the fly

Important files

Discussion points

Is Math.random() good enough?

src/client.ts Fixed Show fixed Hide fixed
src/client.ts Dismissed Show dismissed Hide dismissed
Copy link
Member

@Tymek Tymek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Math.random() good enough?

I think so. In the end we only need it to decide rollout here. Should be good enough for 0.1% splits after our hashing

@sighphyre
Copy link
Member

Is Math.random() good enough?

I think so. In the end we only need it to decide rollout here. Should be good enough for 0.1% splits after our hashing

Yeah agreed, I don't think it matters that much in this context

src/client.ts Dismissed Show dismissed Hide dismissed
@kwasniew kwasniew merged commit a357a07 into main Oct 18, 2023
3 checks passed
@kwasniew kwasniew deleted the default-session-id branch October 18, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants