Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: version bump #156

Merged
merged 1 commit into from
Oct 19, 2023
Merged

chore: version bump #156

merged 1 commit into from
Oct 19, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Oct 19, 2023

About the changes

Version bump. I'm skipping 0.18.1 since I created a tag pointing to the wrong version. This one will get a new tag and a new package.json version

Important files

Discussion points

@@ -1,6 +1,6 @@
{
"name": "@unleash/proxy",
"version": "0.18.0",
"version": "0.18.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Any idea what happened to 0.18.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created incorrect tag 0.18.1 pointing to 0.18.0 without bumping package.json. I prefer not to mutate anything and roll forward instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha! No worries, was just curious

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwasniew kwasniew merged commit 8198ee4 into main Oct 19, 2023
4 checks passed
@kwasniew kwasniew deleted the version-bump-0.18.2 branch October 19, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants